WorldGuard Build #1877

Be aware that this branch (async-command-builder) is not the main branch (master)!

Branches other than the main one may be experimental. In addition, you should be using stable releases rather than these test builds.


Go to main branch View stable downloads

Project WorldGuard
Status FAILURE
Branch async-command-builder
Number #1877-1aab5b4
Date 1 week ago
Artifacts

No artifacts (files) are available for this build!

Changes
ID Summary Committer Date
1aab5b45 Remove AsyncCommandHelper for new AsyncCommandBuilder. Helper suffers from race conditions for short-lived tasks, leading to some poor UX conditions such as errors not propagating to the user (because the exception handler wasn't attached to the future yet), or lack of success messages. This commit replaces that system by a Builder which takes a callable to begin, and then takes supervisor, delay message, and the success and failure messages and handlers as parts of the builder. The success and failure handlers wrap the callable itself before submitting to the executor so they will always be run. The supervisor and delay are added as listeners to the future since they aren't required if the task is sufficiently short-lived (and to maintain compatibility with the classes which are now in WorldEdit). The builder also supports Components for success and failure messages, as well as consumers of the callable's result or exception for better customization of output, instead of having to rely on adding a callback to the future. wizjany 1 week ago