CraftBook Build #4947

This is not a stable download!

We recommend the use of released versions whenever possible.

View Stable Downloads
ProjectCraftBook
StatusSUCCESS
Branchmaster
Number#4947-eee8a17
Date7 days ago
Artifacts

Sponsor
Apex Hosting
Changes
IDSummaryCommitterDate
eee8a179
  • Fix three jukebox item bugs in pipes (#1372)
    • Fix jukebox disc duplication and item loss in pipes The jukebox branch created a new disc ItemStack and only emptied the jukebox if every item was delivered. When the network was full or missing, the copy dropped at the piston while the original kept playing, so a clocked piston printed discs. It was also the only branch that never fed leftovers, so an empty jukebox silently destroyed any items a pipe request delivered into it. Now the disc is removed from the jukebox before the event fires, and undelivered items go through leftovers like the other branches.
    • Fix pipes destroying the disc in a playing jukebox The put-path test was inverted: a disc was only inserted when the jukebox was already playing, so an empty jukebox never accepted one, and when it did fire, setPlaying overwrote the playing disc and destroyed it. Now only an empty jukebox accepts a disc, and a disc that does not fit flows on through the pipe like any other undelivered item.
    • Address review: drop the changelog comments, always fire PipeSuckEvent
59487370+rasmuskd@users.noreply.github.com7 days ago