Apply suggestions from code review
Co-authored-by: Octavia Togami <octavia.togami@gmail.com>
Resolve many of octy's review notes
Further review fixes
Further review improvements
Fix symlink check
PR notes
Few fixes from review
IntelliJ stop resetting this config option challenge
feedback
remove the unused function (c933b7a7 by Maddy Miller)
Remove unncessary (un)init log points (ce5385d9 by markus ebner)
Rename Schematic to SchematicPath and cleanup
- Resolve first batch of review comments
- Renamed Schematic to SchematicPath
- Removed custom hashCode() and equals() implementations
- Added unit-test to make sure it behaves as expected (dd82bfd5 by markus ebner)
Add command suggestions for schematic filenames (f6b02345 by markus ebner)
Implement SchematicsManager to cache list of known schematics (7b794777 by markus ebner)
Add setBiome override in MaskingExtent.
This makes biome operations respect masks set on an EditSession. (dc92f6fc by wizjany)
Fix tree generators working on the unbuffered underlying world. (#2705)
Adds two methods to EditSession to allow getting blocks which are buffered by the EditSession, not yet set in the world.
This allows the proxies used by tree generators to know the eventual state of the world, rather than the "real" state. (f002c034 by wizjany)
Just re-throw here given it's already an extremely niche condition and will block commands
---------
Co-authored-by: Maddy Miller <mnmiller1@me.com> (b0c14624 by sirywell)
Add parent dir to manifest classpath to account for paper-remapped load point.
Currently, the remapped WorldEdit jar on paper is loaded from a sub-directory of the plugins folder, meaning dependencies like truezip and rhino won't be found in the documented search locations. Adding the parent dir temporarily solves this.
See #2692.
Closes #2691. (db49cea6 by wizjany)
Merge pull request #2674 from EngineHub/ot/bugfix/actually-wait-is-this-a-feature
Fix block entities in features/structures (e2cc52c1 by Octavia Togami)
Correct all BlockTools to use the Location's World (#2650)
All tools would inadvertently use the player's World at some point,
which is incorrect in the presense of some mods as seen in #2560
Fixes #2560 (6c40aed7 by Octavia Togami)
Merge pull request #2644 from EngineHub/ot/fix/the-magic-is-fading
Directly access the data version from MC (4225ae29 by Octavia Togami)
Directly access the data version from MC
Spigot recently made a breaking change to CraftMagicNumbers which breaks
this code, by using MC directly we avoid this issue ever occuring in the
future (bae1b650 by Octavia Togami)
